Properly deprecate non-1D inputs to pie(). #13354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f1b774 to
2a02d73
Compare
timhoffm
approved these changes
Feb 6, 2019
lib/matplotlib/axes/_axes.py
Outdated
| @@ -2725,7 +2725,7 @@ def pie(self, x, explode=None, labels=None, colors=None, | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| x : array-like | |||
| x : 1D array-like | |||
There was a problem hiding this comment.
Not necessarily needed. We generally assume array-like to be 1D if the parameter is semantically only 1D.
| x = np.array(x, np.float32) | ||
| # The use of float32 is "historical", but can't be changed without | ||
| # regenerating the test baselines. | ||
| x = np.asarray(x, np.float32) |
There was a problem hiding this comment.
Could be changed to float64, and only patched back in some way to float32 for the tests. But that's beyond this PR.
There was a problem hiding this comment.
seems not worth the effort, frankly
This PR also restores (... for the duration of the deprecation) the support for non-1D inputs that can be squeezed to a 1D array that was broken with numpy 1.16.
jklymak
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also restores (... for the duration of the deprecation) the
support for non-1D inputs that can be squeezed to a 1D array that was
broken with numpy 1.16.
Closes #13286, although someone may want to additionally backport the fix (without the deprecations) to 3.0.x.
PR Summary
PR Checklist