Properly deprecate non-1D or string inputs to pie().

anntzer · anntzer · commit 5f1b77491410 · 2019-02-03T23:29:35.000+01:00
This PR also restores (... for the duration of the deprecation) the
support for non-1D inputs that can be squeezed to a 1D array that was
broken with numpy 1.16.
diff --git a/doc/api/next_api_changes/2018-02-03-AL.rst b/doc/api/next_api_changes/2018-02-03-AL.rst
@@ -0,0 +1,6 @@
+Deprecations
+````````````
+
+Passing a non-1D (typically, (n, 1)-shaped) input, or an array of floats in
+"string" form (e.g., ``["0.1", "0.2"]``) to `Axes.pie` is deprecated.  Pass a
+1D array of floats instead.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -2725,7 +2725,7 @@ def pie(self, x, explode=None, labels=None, colors=None,
 
         Parameters
         ----------
-        x : array-like
+        x : 1D array-like
             The wedge sizes.
 
         explode : array-like, optional, default: None
@@ -2809,11 +2809,24 @@ def pie(self, x, explode=None, labels=None, colors=None,
         The axes aspect ratio can be controlled with `Axes.set_aspect`.
         """
         self.set_aspect('equal')
-        x = np.array(x, np.float32)
+        x = np.asarray(x)
+        if x.ndim != 1 and x.squeeze().ndim <= 1:
+            cbook.warn_deprecated(
+                "3.1", message="Non-1D inputs to pie() are currently "
+                "squeeze()d, but this behavior is deprecated since %(since)s "
+                "and will be removed %(removal)s; pass a 1D array instead.")
+            x = np.atleast_1d(x.squeeze())
+        if x.dtype.kind in "SU":
+            x = np.asarray(x, float)  # Let the ValueError propagate.
+            cbook.warn_deprecated(
+                "3.1", message="String inputs to pie() are currently "
+                "converted to floats, but this behavior is deprecated since "
+                "%(since)s and will be removed %(removal)s; pass an array of "
+                "floats instead.")
 
         sx = x.sum()
         if sx > 1:
-            x /= sx
+            x = x / sx
 
         if labels is None:
             labels = [''] * len(x)
