Axes.tick_params() argument checking #12210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
approved these changes
Sep 22, 2018
8000
anntzer
reviewed
Sep 22, 2018
lib/matplotlib/axes/_base.py
Outdated
| @@ -2949,6 +2949,8 @@ def tick_params(self, axis='both', **kwargs): | |||
| also be red. Gridlines will be red and translucent. | |||
|
|
|||
| """ | |||
| if axis not in ['x', 'y', 'both']: | |||
| raise ValueError("axis must be one of 'x', 'y' or 'both'.") | |||
There was a problem hiding this comment.
no dot at end of exception messages (that's both what we do and consistent with the stdlib)
1b9b4b4 to
2642831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Axes.tick_paramssilently did nothing when an invalid axis parameter wassupplied. This behavior is changed to raise a ValueError instead.
PR Checklist