Merge pull request #12210 from timhoffm/axes-tick_params-checking

anntzer · web-flow · commit 03b07fbcb30a · 2018-09-22T15:59:36.000+02:00
Axes.tick_params() argument checking
diff --git a/doc/api/next_api_changes/2018-09-22-TH.rst b/doc/api/next_api_changes/2018-09-22-TH.rst
@@ -0,0 +1,5 @@
+Axes.tick_params argument checking
+``````````````````````````````````
+
+`Axes.tick_params` silently did nothing when an invalid *axis* parameter was
+supplied. This behavior is changed to raise a ValueError instead.
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -2949,6 +2949,8 @@ def tick_params(self, axis='both', **kwargs):
         also be red.  Gridlines will be red and translucent.
 
         """
+        if axis not in ['x', 'y', 'both']:
+            raise ValueError("axis must be one of 'x', 'y' or 'both'")
         if axis in ['x', 'both']:
             xkw = dict(kwargs)
             xkw.pop('left', None)
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -1412,7 +1412,10 @@ def tick_params(self, axis='both', **kwargs):
         .. versionadded :: 1.1.0
             This function was added, but not tested. Please report any bugs.
         """
-        super().tick_params(axis, **kwargs)
+        if axis not in ['x', 'y', 'z', 'both']:
+            raise ValueError("axis must be one of 'x', 'y', 'z' or 'both'")
+        if axis in ['x', 'y', 'both']:
+            super().tick_params(axis, **kwargs)
         if axis in ['z', 'both']:
             zkw = dict(kwargs)
             zkw.pop('top', None)
