Fix Flash of Unstyled Content by removing remaining Flipcause integration #12182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes all remaining Flipcause integration code. The problem is the <iframe> in the footer that is part of the Flipcause integration. Removing it gets rid of the FOUC. It appears that the entire Flipcause integration is not used anymore since commit 5c3b3ef, in which the JavaScript Flipcause buttons were replaced with normal links. That commit removed the JavaScript part of the Flipcause integration, but not the styles.
A space character was missing
|
Similar to #12181 this should be PR'ed against the master branch, not v3.0.0-doc. |
|
Yes, thanks, I had to search a bit until I found where I had to click to change the base branch. |
timhoffm
approved these changes
Sep 20, 2018
|
@meeseeksdev backport to v3.0.0-doc |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 21, 2018
…ng remaining Flipcause integration
tacaswell
added a commit
that referenced
this pull request
Sep 21, 2018
…182-on-v3.0.0-doc Backport PR #12182 on branch v3.0.0-doc (Fix Flash of Unstyled Content by removing remaining Flipcause integration)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to fix the “Flash of Unstyled Content” when loading any matplotlib documentation site (just reload a couple of times and it is quite visible). The problem is the
<iframe>in the footer that is part of the Flipcause integration. Removing it gets rid of the FOUC.It appears that the entire Flipcause integration is not used anymore
since commit 5c3b3ef, in which
the JavaScript Flipcause buttons were replaced with normal links. That
commit removed the JavaScript part of the Flipcause integration, but
not the styles. This PR removes the rest.
I could not test this locally as my Sphinx build would not finish.