8000 Fix non-functional Sphinx link by marcelm · Pull Request #12181 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix non-functional Sphinx link #12181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix non-functional Sphinx link #12181

wants to merge 1 commit into from

Conversation

marcelm
Copy link
Contributor
@marcelm marcelm commented Sep 20, 2018

A space character was missing

GitHub’s syntax highlighting caught this while browsing https://github.com/matplotlib/matplotlib/blob/b3154da1bc688a4dba821547ad4edfcf6d986cd2/doc/_templates/layout.html

A space character was missing
@ImportanceOfBeingErnest
Copy link
Member

Thanks for that. However, this PR should be created against the master branch (and then potentially backported).

@marcelm
Copy link
Contributor Author
marcelm commented Sep 20, 2018

I noted that some parts of the homepage had only been changed in the v3.0.0-doc branch, not master, so I assumed that was the correct branch, sorry about that.

I’ll combine this with the other PR #12182, which I guess I’ll also have to re-submit against master.

@QuLogic
Copy link
Member
QuLogic commented Sep 20, 2018

However, this PR should be created against the master branch (and then potentially backported).

There is no requirement for this; the older branches get merged up periodically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0