8000 [MABL-6856] Update Moment and Additional Improvements by twistedpair · Pull Request #53 · mablhq/github-run-tests-action · GitHub
[go: up one dir, main page]
Skip to content

[MABL-6856] Update Moment and Additional Improvements #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 12, 2022
Merged

[MABL-6856] Update Moment and Additional Improvements #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3714054
Update and pin
twistedpair Apr 9, 2022
dfc3435
Upgrade to Node.js v16
twistedpair Apr 9, 2022
a439be1
Package cleanup
twistedpair Apr 9, 2022
54c4846
Cleanup
twistedpair Apr 9, 2022
3efb4e7
Add timeouts
twistedpair Apr 10, 2022
02bfc80
PR feedback
twistedpair Apr 11, 2022
f499f20
Update timeouts
twistedpair Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 52 additions & 8 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,62 @@
"@typescript-eslint/await-thenable": "error",

"camelcase": "off",
"@typescript-eslint/camelcase": ["error", { "properties": "never", "allow": ["^[A-Za-z][a-zA-Za-z]+_[A-Za-z]+$"] }],
"@typescript-eslint/naming-convention": [
"error",
{
"selector": "default",
"format": ["camelCase"]
},
{
"selector": "classProperty",
"modifiers": ["private"],
"format": ["camelCase"],
"leadingUnderscore": "allow"
},
{
"selector": "classProperty",
"modifiers": ["protected"],
"format": ["camelCase"],
"leadingUnderscore": "allow"
},
{
"selector": "objectLiteralProperty",
"format": null
},
{
"selector": "typeProperty",
"format": null
},
{
"selector": "variable",
"format": ["PascalCase", "camelCase", "UPPER_CASE"]
},
{
"selector": "parameter",
"format": ["camelCase"],
"leadingUnderscore": "allow"
},
{
"selector": "enumMember",
"format": ["snake_case", "camelCase", "PascalCase", "UPPER_CASE"]
},
{
"selector": "typeLike",
"format": ["PascalCase"]
},
{
"selector": "interface",
"format": ["PascalCase"],
"custom": {
"regex": "^I[A-Z]",
"match": false
}
}
],

"@typescript-eslint/class-name-casing": "error",
"@typescript-eslint/consistent-type-definitions": ["error", "interface"],
"@typescript-eslint/consistent-type-assertions": ["error", { "assertionStyle": "as"}],
"@typescript-eslint/explicit-function-return-type": ["error"],
"@typescript-eslint/interface-name-prefix": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed in the latest versions of eslint, and moved to a more general rule.

"@typescript-eslint/no-extra-parens": ["error", "all", {
"returnAssign": false,
"nestedBinaryExpressions": false,
"enforceForArrowConditionals": false
}],
"@typescript-eslint/no-extra-semi": "error",
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-inferrable-types": "error",
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ jobs:

- `MABL_API_KEY` {string} - Your mabl API key
[available here](https://app.mabl.com/workspaces/-/settings/apis) This should
be installed as a secret in your github repository.
- `GITHUB_TOKEN` {string} (optional) - The Github token for your repository. If
be installed as a secret in your GitHub repository.
- `GITHUB_TOKEN` {string} (optional) - The GitHub token for your repository. If
provided, the mabl action will associate a pull request with the deployment if
the commit being built is associated with any pull requests. This token is
automatically available as a secret in your repo but must be passed in
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,5 @@ outputs:
description: "Number of mabl tests that failed against this deployment."

runs:
using: "node12"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to the future, Node.js v12 is EoL.

using: "node16"
main: "lib/src/index.js"
Loading
0