[MABL-6856] Update Moment and Additional Improvements #53
Conversation
| "@typescript-eslint/consistent-type-definitions": ["error", "interface"], | ||
| "@typescript-eslint/consistent-type-assertions": ["error", { "assertionStyle": "as"}], | ||
| "@typescript-eslint/explicit-function-return-type": ["error"], | ||
| "@typescript-eslint/interface-name-prefix": "error", |
There was a problem hiding this comment.
These were removed in the latest versions of eslint, and moved to a more general rule.
| @@ -75,5 +75,5 @@ outputs: | |||
| description: "Number of mabl tests that failed against this deployment." | |||
|
|
|||
| runs: | |||
| using: "node12" | |||
There was a problem hiding this comment.
Moving to the future, Node.js v12 is EoL.
| @@ -1,5 +1,5 @@ | |||
| import {Execution, JourneyInfo} from './entities/ExecutionResult'; | |||
| import Table, {HorizontalTable} from 'cli-table3'; | |||
There was a problem hiding this comment.
Interface changed.
| @@ -140,7 +140,7 @@ export class MablApiClient { | |||
| httpHeaders: string[], | |||
| rebaselineImages: boolean, | |||
| setStaticBaseline: boolean, | |||
| event_time: number, | |||
There was a problem hiding this comment.
Non-compliant variable name.
| } catch (error) { | ||
| if (error.status !== 404) { | ||
| core.warning(error.message); | ||
| } catch (error: unknown) { |
There was a problem hiding this comment.
Required for latest Typescript compiler.
| @@ -6,10 +6,13 @@ import axios, {AxiosInstance, AxiosRequestConfig} from 'axios'; | |||
| import {Environment} from './entities/Environment'; | |||
| import {USER_AGENT} from './constants'; | |||
|
|
|||
| const GET_REQUEST_TIMEOUT_MILLIS = 60_000; | |||
| const POST_REQUEST_TIMEOUT_MILLIS = 900_000; | |||
There was a problem hiding this comment.
@jbaldassari , is this the same timeout logic you added in the CLI, for deployments pulling?
I want to address the PR description linked customer issue where this Action appears to hang.
There was a problem hiding this comment.
I think it's a little bit of a different situation in mabl-cli because we have the auto-retry logic in there too, but we're using very liberal timeouts now: https://github.com/mablhq/mabl-cli/blob/master/runtime/src/api/mablApiClient.ts#L127-L130
The individual request uses no timeout (0), and the retryable wrapper uses a 1 hour timeout
momentto address CVE-2022-24785