[]

localstack · MEPalma · Jul 14, 2023 · May 8, 2023 · May 10, 2023 · May 10, 2023
commit a73fe6870cc0d8a3f44aadb11a90d42ed6132bb4
diff --git a/localstack/services/stepfunctions/asl/component/state/state_fail/state_fail.py b/localstack/services/stepfunctions/asl/component/state/state_fail/state_fail.py
@@ -1,11 +1,18 @@
 from typing import Optional
 
-from localstack.aws.api.stepfunctions import HistoryEventType
+from localstack.aws.api.stepfunctions import HistoryEventType, TaskFailedEventDetails
 from localstack.services.stepfunctions.asl.component.common.cause_decl import CauseDecl
 from localstack.services.stepfunctions.asl.component.common.error_decl import ErrorDecl
+from localstack.services.stepfunctions.asl.component.common.error_name.custom_error_name import (
+    CustomErrorName,
+)
+from localstack.services.stepfunctions.asl.component.common.error_name.failure_event import (
+    FailureEvent,
+)
 from localstack.services.stepfunctions.asl.component.state.state import CommonStateField
 from localstack.services.stepfunctions.asl.component.state.state_props import StateProps
 from localstack.services.stepfunctions.asl.eval.environment import Environment
+from localstack.services.stepfunctions.asl.eval.event.event_detail import EventDetails
 
 
 class StateFail(CommonStateField):
@@ -23,5 +30,13 @@ def from_state_props(self, state_props: StateProps) -> None:
         self.error = state_props.get(ErrorDecl)
 
     def _eval_state(self, env: Environment) -> None:
-        # TODO.
-        env.set_error(self)
+        failure_event = FailureEvent(
+            error_name=CustomErrorName(self.error.error),
+            event_type=HistoryEventType.TaskFailed,
+            event_details=EventDetails(
+                taskFailedEventDetails=TaskFailedEventDetails(
+                    error=self.error.error, cause=self.cause.cause
+                )
+            ),
+        )
+        env.stack.append(failure_event)
diff --git a/tests/integration/stepfunctions/templates/base/base_templates.py b/tests/integration/stepfunctions/templates/base/base_templates.py
@@ -11,3 +11,4 @@ class BaseTemplate(TemplateLoader):
     BASE_PASS_RESULT: Final[str] = os.path.join(_THIS_FOLDER, "statemachines/pass_result.json5")
     BASE_TASK_SEQ_2: Final[str] = os.path.join(_THIS_FOLDER, "statemachines/task_seq_2.json5")
     BASE_WAIT_1_MIN: Final[str] = os.path.join(_THIS_FOLDER, "statemachines/wait_1_min.json5")
+    BASE_RAISE_FAILURE: Final[str] = os.path.join(_THIS_FOLDER, "statemachines/raise_failure.json5")
diff --git a/tests/integration/stepfunctions/templates/base/statemachines/raise_failure.json5 b/tests/integration/stepfunctions/templates/base/statemachines/raise_failure.json5
@@ -0,0 +1,11 @@
+{
+  "Comment": "BASE_RAISE_FAILURE",
+  "StartAt": "FailState",
+  "States": {
+    "FailState": {
+      "Type": "Fail",
+      "Error": "SomeFailure",
+      "Cause": "This state machines raises a 'SomeFailure' failure."
+    },
+  },
+}
diff --git a/tests/integration/stepfunctions/v2/callback/test_callback.py b/tests/integration/stepfunctions/v2/callback/test_callback.py
@@ -236,3 +236,49 @@ def test_start_execution_sync(
             definition,
             exec_input,
         )
+
+    def test_start_execution_sync_delegate_failure(
+        self,
+        aws_client,
+        create_iam_role_for_sfn,
+        create_state_machine,
+        sfn_snapshot,
+    ):
+        sfn_snapshot.add_transformer(
+            JsonpathTransformer(
+                jsonpath="$..output.StartDate",
+                replacement="start-date",
+                replace_reference=False,
+            )
+        )
+        sfn_snapshot.add_transformer(
+            JsonpathTransformer(
+                jsonpath="$..cause.StartDate",
+                replacement="stop-date",
+                replace_reference=False,
+            )
+        )
+
+        template_target = BT.load_sfn_template(BT.BASE_RAISE_FAILURE)
+        definition_target = json.dumps(template_target)
+        state_machine_arn_target = create(
+            create_iam_role_for_sfn,
+            create_state_machine,
+            sfn_snapshot,
+            definition_target,
+        )
+
+        template = CT.load_sfn_template(CT.SFN_START_EXECUTION_SYNC)
+        definition = json.dumps(template)
+
+        exec_input = json.dumps(
+            {"StateMachineArn": state_machine_arn_target, "Input": None, "Name": "TestStartTarget"}
+        )
+        create_and_record_execution(
+            aws_client.stepfunctions,
+            create_iam_role_for_sfn,
+            create_state_machine,
+            sfn_snapshot,
+            definition,
+            exec_input,
+        )
diff --git a/tests/integration/stepfunctions/v2/callback/test_callback.snapshot.json b/tests/integration/stepfunctions/v2/callback/test_callback.snapshot.json
@@ -779,5 +779,171 @@
         }
       }
     }
+  },
+  "tests/integration/stepfunctions/v2/callback/test_callback.py::TestCallback::test_start_execution_sync_delegate_failure": {
+    "recorded-date": "03-07-2023, 11:11:56",
+    "recorded-content": {
+      "get_execution_history": {
+        "events": [
+          {
+            "executionStartedEventDetails": {
+              "input": {
+                "StateMachineArn": "arn:aws:states:<region>:111111111111:stateMachine:<ArnPart_0idx>",
+                "Input": null,
+                "Name": "TestStartTarget"
+              },
+              "inputDetails": {
+                "truncated": false
+              },
+              "roleArn": "snf_role_arn"
+            },
+            "id": 1,
+            "previousEventId": 0,
+            "timestamp": "timestamp",
+            "type": "ExecutionStarted"
+          },
+          {
+            "id": 2,
+            "previousEventId": 0,
+            "stateEnteredEventDetails": {
+              "input": {
+                "StateMachineArn": "arn:aws:states:<region>:111111111111:stateMachine:<ArnPart_0idx>",
+                "Input": null,
+                "Name": "TestStartTarget"
+              },
+              "inputDetails": {
+                "truncated": false
+              },
+              "name": "StartExecution"
+            },
+            "timestamp": "timestamp",
+            "type": "TaskStateEntered"
+          },
+          {
+            "id": 3,
+            "previousEventId": 2,
+            "taskScheduledEventDetails": {
+              "parameters": {
+                "Input": null,
+                "StateMachineArn": "arn:aws:states:<region>:111111111111:stateMachine:<ArnPart_0idx>",
+                "Name": "TestStartTarget"
+              },
+              "region": "<region>",
+              "resource": "startExecution.sync",
+              "resourceType": "states"
+            },
+            "timestamp": "timestamp",
+            "type": "TaskScheduled"
+          },
+          {
+            "id": 4,
+            "previousEventId": 3,
+            "taskStartedEventDetails": {
+              "resource": "startExecution.sync",
+              "resourceType": "states"
+            },
+            "timestamp": "timestamp",
+            "type": "TaskStarted"
+          },
+          {
+            "id": 5,
+            "previousEventId": 4,
+            "taskSubmittedEventDetails": {
+              "output": {
+                "ExecutionArn": "arn:aws:states:<region>:111111111111:execution:<ArnPart_0idx>:TestStartTarget",
+                "SdkHttpMetadata": {
+                  "AllHttpHeaders": {
+                    "x-amzn-RequestId": [
+                      "<uuid:1>"
+                    ],
+                    "connection": [
+                      "keep-alive"
+                    ],
+                    "Content-Length": [
+                      "161"
+                    ],
+                    "Date": "date",
+                    "Content-Type": [
+                      "application/x-amz-json-1.0"
+                    ]
+                  },
+                  "HttpHeaders": {
+                    "connection": "keep-alive",
+                    "Content-Length": "161",
+                    "Content-Type": "application/x-amz-json-1.0",
+                    "Date": "date",
+                    "x-amzn-RequestId": "<uuid:1>"
+                  },
+                  "HttpStatusCode": 200
+                },
+                "SdkResponseMetadata": {
+                  "RequestId": "<uuid:1>"
+                },
+                "StartDate": "start-date"
+              },
+              "outputDetails": {
+                "truncated": false
+              },
+              "resource": "startExecution.sync",
+              "resourceType": "states"
+            },
+            "timestamp": "timestamp",
+            "type": "TaskSubmitted"
+          },
+          {
+            "id": 6,
+            "previousEventId": 5,
+            "taskFailedEventDetails": {
+              "cause": {
+                "Cause": "This state machines raises a 'SomeFailure' failure.",
+                "Error": "SomeFailure",
+                "ExecutionArn": "arn:aws:states:<region>:111111111111:execution:<ArnPart_0idx>:TestStartTarget",
+                "Input": "{}",
+                "InputDetails": {
+                  "Included": true
+                },
+                "Name": "TestStartTarget",
+                "StartDate": "stop-date",
+                "StateMachineArn": "arn:aws:states:<region>:111111111111:stateMachine:<ArnPart_0idx>",
+                "Status": "FAILED",
+                "StopDate": 1688375513430
+              },
+              "error": "States.TaskFailed",
+              "resource": "startExecution.sync",
+              "resourceType": "states"
+            },
+            "timestamp": "timestamp",
+            "type": "TaskFailed"
+          },
+          {
+            "executionFailedEventDetails": {
+              "cause": {
+                "Cause": "This state machines raises a 'SomeFailure' failure.",
+                "Error": "SomeFailure",
+                "ExecutionArn": "arn:aws:states:<region>:111111111111:execution:<ArnPart_0idx>:TestStartTarget",
+                "Input": "{}",
+                "InputDetails": {
+                  "Included": true
+                },
+                "Name": "TestStartTarget",
+                "StartDate": "stop-date",
+                "StateMachineArn": "arn:aws:states:<region>:111111111111:stateMachine:<ArnPart_0idx>",
+                "Status": "FAILED",
+                "StopDate": 1688375513430
+              },
+              "error": "States.TaskFailed"
+            },
+            "id": 7,
+            "previousEventId": 6,
+            "timestamp": "timestamp",
+            "type": "ExecutionFailed"
+          }
+        ],
+        "ResponseMetadata": {
+          "HTTPHeaders": {},
+          "HTTPStatusCode": 200
+        }
+      }
+    }
   }
 }