8000 [SFN] Support for SFN and Sync, reworked exception handling, fixes, tests by MEPalma · Pull Request #8623 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

[SFN] Support for SFN and Sync, reworked exception handling, fixes, tests #8623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Jul 14, 2023

Conversation

MEPalma
Copy link
Contributor
@MEPalma MEPalma commented Jul 5, 2023

Adds support for:

  • Optimised integration for stepfunctions states
  • sync functionality

Reworks exception handling design:

  • introduces FailureEventException carrying required information about the failure
  • ensures State.Runtime errors are always raised on terminal internal errors

Fixes several issues relevant to state Fail, describe execution output, and adds relevant tests

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 5, 2023
@MEPalma MEPalma self-assigned this Jul 5, 2023
@github-actions
Copy link
github-actions bot commented Jul 5, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 26m 27s ⏱️
2 230 tests 1 888 ✔️ 342 💤 0
2 231 runs  1 888 ✔️ 343 💤 0

Results for commit e4985ee.

♻️ This comment has been updated with latest results.

@coveralls
Copy link
coveralls commented Jul 6, 2023

Coverage Status

coverage: 82.152% (-0.05%) from 82.204% when pulling e4985ee on MEP- 8000 sfn-sync-and-sfn into 751c1ec on master.

@MEPalma MEPalma marked this pull request as ready for review July 6, 2023 11:01
@MEPalma MEPalma requested a review from dominikschubert as a code owner July 6, 2023 11:01
@MEPalma MEPalma added this to the 2.2 milestone Jul 12, 2023
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

< 8000 summary role="button" data-target="details-collapsible.summaryElement details-toggle.summaryTarget" data-action="click:details-collapsible#toggle click:details-toggle#toggle" data-aria-label-closed="Expand comment" data-aria-label-open="Collapse comment" aria-expanded="false" aria-label="Collapse comment" data-view-component="true" class="js-toggle-outdated-comments py-2 px-3 rounded-2 color-bg-subtle">
@MEPalma MEPalma merged commit 102d7bd into master Jul 14, 2023
@MEPalma MEPalma deleted the MEP-sfn-sync-and-sfn branch July 14, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0