Fix Kinesis -related Authorization header parsing (via kinesis-mock version update) #7375
Conversation
We found an issue with localstack that ended up being an issue within the kinesis-mock dependency We opened GitHub issues in both places, had help from the maintainer of kinesis-mock, who gently provided a fix for, as well as tagging the service - and we're now pulling it into LocalStack
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
CONTRIBUTING.md
Outdated
| @@ -6,6 +6,7 @@ For pull requests, please stick to the following guidelines: | |||
|
|
|||
| * Add tests for any new features and bug fixes. Ideally, each PR should increase the test coverage. | |||
| * Follow the existing code style. Run `make format` and `make lint` before checking in your code. | |||
| * This might involve previous runs of `make venv` and `make install`, in order to have proper local setup. | |||
There was a problem hiding this comment.
Sorry you encountered some difficulties while setting LocalStack up.
Maybe we could rewrite that line with a link to https://docs.localstack.cloud/contributing/development-environment-setup/ to help new contributors?
There was a problem hiding this comment.
There was a problem hiding this comment.
If you prefer something else, would you be so kind as to use the "suggestion" mechanism from GitHub? Thank you.
There was a problem hiding this comment.
Thanks a lot for the change, it's true, I could have used the "suggestion" mechanism first, sorry!
Closes #7358.
Ran:
make venv,make install,make format,make lint, andmake test.Pushing to check how CI reacts.