10000 Fix Kinesis -related Authorization header parsing (via kinesis-mock version update) by paulo-ferraz-oliveira · Pull Request #7375 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix Kinesis -related Authorization header parsing (via kinesis-mock version update) #7375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Fix Kinesis -related Authorization header parsing (via kinesis-mock version update) #7375

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edf75ef
Allow comma (followed by no space) to separate Authorization parameters
paulo-ferraz-oliveira Dec 20, 2022
12b52d8
Potentially ease future contributions
paulo-ferraz-oliveira Dec 20, 2022
7e0411e
React to pull request review
paulo-ferraz-oliveira Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
React to pull request review
  • Loading branch information
@paulo-ferraz-oliveira
paulo-ferraz-oliveira committed Dec 21, 2022
commit 7e0411eb4b78815ac755969234a17372d77bb9de
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ For pull requests, please stick to the following guidelines:

* Add tests for any new features and bug fixes. Ideally, each PR should increase the test coverage.
* Follow the existing code style. Run `make format` and `make lint` before checking in your code.
* This might involve previous runs of `make venv` and `make install`, in order to have proper local setup.
* Refer to [Development Environment Setup](https://docs.localstack.cloud/contributing/development-environment-setup/) if your local testing environment is not yet properly set up.
* Put a reasonable amount of comments into the code.
* Fork localstack on your GitHub user account, do your changes there and then create a PR against main localstack repository.
* Separate unrelated changes into multiple pull requests.
Expand Down
0