8000 fix(providers): Removed cloudcontrol provider by Pive01 · Pull Request #11920 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content
8000

fix(providers): Removed cloudcontrol provider #11920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(providers): Removed cloudcontrol provider #11920

merged 1 commit into from
Nov 25, 2024

Conversation

Pive01
Copy link
Contributor
@Pive01 Pive01 commented Nov 25, 2024

Motivation

Removed cloudcontrol provider for community as we moved it in pro

Changes

Removed cloudcontrol from the list of community providers

@Pive01 Pive01 added the semver: patch Non-breaking changes which can be included in patch releases label Nov 25, 2024
@Pive01 Pive01 requested review from simonrw and silv-io November 25, 2024 10:09
silv-io
silv-io approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member
@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?

If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

@Pive01
Copy link
Contributor Author
Pive01 commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?

If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

@silv-io
Copy link
Member
silv-io commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?
If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

In that PR I can only see it being added to pro, but where was that removed from community?

@Pive01
Copy link
Contributor Author
Pive01 commented Nov 25, 2024

Is the code in localstack.services.cloudcontrol.provider also migrated to PRO?
If yes, then it's alright. Otherwise we'd have to take a look at that as well before merging

Yes, everything has been moved here

In that PR I can only see it being added to pro, but where was that removed from community?

Was never added in the first time, initially was added but half way through we moved it

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files      2 suites   1h 48m 9s ⏱️
3 724 tests 3 377 ✅ 347 💤 0 ❌
3 726 runs  3 377 ✅ 349 💤 0 ❌

Results for commit 1da2503.

@Pive01 Pive01 merged commit 08ad92b into master Nov 25, 2024
35 of 36 checks passed
@Pive01 Pive01 deleted the cloudcontorl-cleanup branch November 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

@silv-io silv-io silv-io approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pive01 @silv-io @simonrw
0