feat(CloudControl): Introduces list operations for bunch of services so cloudcontrol can pick them up #11830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
|
I have read the CLA Document and I hereby sign the CLA |
localstack-bot
added a commit
that referenced
this pull request
Nov 12, 2024
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 47s ⏱️ Results for commit 351eab8. ♻️ This comment has been updated with latest results. |
8467298 to
ef36df6
Compare
giograno
reviewed
Nov 13, 2024
localstack-core/localstack/services/apigateway/resource_providers/aws_apigateway_resource.py
Outdated
Show resolved
Hide resolved
With the caveat that we don't yet support "simple" identifiers, as this will require looking up the physical resource id field in the spec and constructing a new payload
Path args for regiona and account. Wrap list resources in a try except (some clients throw errors if the resource model is not provided (e.g., apigw)
As discussed with Luca for the usage from the frontend
Aggregate everything under resource type
e317dfc to
351eab8
Compare
simonrw
approved these changes
Nov 18, 2024
giograno
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to support the Resource Overview project we need some:
Changes
Introduce CloudFormation list-types operations to list supported types by cloudcontrol
Relative -ext PR https://github.com/localstack/localstack-ext/pull/3699
/cc @simonrw @dominikschubert