fixed s3 deletion from stack in cdk #11700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Oct 21, 2024
| @@ -243,9 +243,10 @@ def provision(self, skip_deployment: Optional[bool] = False): | |||
| ] | |||
|
|
|||
| for s3_bucket in s3_buckets: | |||
| bucket_to_delete = s3_bucket # Capture current value | |||
There was a problem hiding this comment.
FYI: this line doesn't actually do anything in regards to the root cause, it would still lead to the same issue
There was a problem hiding this comment.
Thanks for the suggestion. I've removed this line.
| lambda bucket=bucket_to_delete: cleanup_s3_bucket( | ||
| self.aws_client.s3, bucket, delete_bucket=False |
There was a problem hiding this comment.
Suggested change
| lambda bucket=bucket_to_delete: cleanup_s3_bucket( | |
| self.aws_client.s3, bucket, delete_bucket=False | |
| lambda s3_bucket=s3_bucket: cleanup_s3_bucket( | |
| self.aws_client.s3, s3_bucket, delete_bucket=False |
this alone would be enough to bind the value here
There was a problem hiding this comment.
I've update the lambda to use the loop variable.
60d796a to
1b8f9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to fix the S3 bucket cleaning when a stack contains more than one buckets (with objects in it). According to my theory due to late binding in the lambda function, the
cleanup_s3_bucketis not able to get the reference to the actual variable.Changes