fixed s3 deletion from stack in cdk

macnev2013 · macnev2013 · commit 60d796ac7895 · 2024-10-16T20:08:10.000+05:30
diff --git a/localstack-core/localstack/testing/scenario/provisioning.py b/localstack-core/localstack/testing/scenario/provisioning.py
@@ -243,9 +243,10 @@ def provision(self, skip_deployment: Optional[bool] = False):
                 ]
 
                 for s3_bucket in s3_buckets:
+                    bucket_to_delete = s3_bucket  # Capture current value
                     self.custom_cleanup_steps.append(
-                        lambda: cleanup_s3_bucket(
-                            self.aws_client.s3, s3_bucket, delete_bucket=False
+                        lambda bucket=bucket_to_delete: cleanup_s3_bucket(
+                            self.aws_client.s3, bucket, delete_bucket=False
                         )
                     )
 

Original file line number	Diff line number	Diff line change
`@@ -243,9 +243,10 @@ def provision(self, skip_deployment: Optional[bool] = False):`
`243`	`243`	`]`
`244`	`244`
`245`	`245`	`for s3_bucket in s3_buckets:`
	`246`	`+ bucket_to_delete = s3_bucket # Capture current value`
`246`	`247`	`self.custom_cleanup_steps.append(`
`247`		`- lambda: cleanup_s3_bucket(`
`248`		`- self.aws_client.s3, s3_bucket, delete_bucket=False`
	`248`	`+ lambda bucket=bucket_to_delete: cleanup_s3_bucket(`
	`249`	`+ self.aws_client.s3, bucket, delete_bucket=False`
`249`	`250`	`)`
`250`	`251`	`)`
`251`	`252`