10000 Add reverted OpenAPI commit by giograno · Pull Request #11452 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Add reverted OpenAPI commit #11452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2024
Merged

Add reverted OpenAPI commit #11452

merged 4 commits into from
Sep 9, 2024

Conversation

giograno
Copy link
Member
@giograno giograno commented Sep 3, 2024 •
edited
Loading

Motivation

With #11025 we involuntarily broke the persistence snapshots in the downstream pipeline. The reasoning is explained in https://github.com/localstack/localstack-ext/pull/3407. The issue should be solved once such PR gets merged.

Changes

  • Re-add the reverted commit.

@giograno giograno added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Sep 3, 2024
@github-action 8000 s GitHub Actions
Copy link
github-actions bot commented Sep 3, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 38s ⏱️
423 tests 369 ✅  54 💤 0 ❌
846 runs  738 ✅ 108 💤 0 ❌

Results for commit a3a42dd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 3, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 39m 23s ⏱️ + 2m 31s
3 425 tests +5  3 027 ✅ +5  398 💤 ±0  0 ❌ ±0 
3 427 runs  +5  3 027 ✅ +5  400 💤 ±0  0 ❌ ±0 

Results for commit a3a42dd. ± Comparison against base commit a50e575.

♻️ This comment has been updated with latest results.

viren-nadkarni and others added 3 commits September 4, 2024 14:28
@viren-nadkarni @giograno
Add OpenAPI schema for public REST API (#11025)
876b3ac 
Co-authored-by: Giovanni Grano <me@giograno.com>
(cherry picked from commit fcd110d)
@giograno
Adjust to latest feedback
d150b6d
8000
@giograno
upgrade pinned deps
cf9d81f
@giograno giograno marked this pull request as ready for review September 5, 2024 09:30
alexrashed
alexrashed approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revert, and adjusting the error handling based on recent feedback, is looking good! I just added two questions, but when they are answered, we can move forward with the merge. 💯

.github/workflows/tests-pro-integration.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: With #11444, the request validation was (similar to the request validation) moved to an opt-in approach.
Would it make sense to activate the request validation here as well?
Or should the opt-in maybe be reverted to an opt-out?

@giograno giograno merged commit 1f82fb1 into master Sep 9, 2024
41 checks passed
@giograno giograno deleted the re-add-openapi branch September 9, 2024 15:09
@giograno giograno mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giograno @alexrashed @viren-nadkarni
0