8000 relax validation for openapi responses · localstack/localstack@a3a42dd · GitHub
[go: up one dir, main page]

Skip to content

Commit a3a42dd

Browse files
committed
relax validation for openapi responses
1 parent cf9d81f commit a3a42dd

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

localstack-core/localstack/aws/handlers/validation.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from openapi_core.validation.request.exceptions import (
1313
RequestValidationError,
1414
)
15+
from openapi_core.validation.response.exceptions import ResponseValidationError
1516

1617
from localstack import config
1718
from localstack.aws.api import RequestContext
@@ -67,7 +68,8 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
6768

6869
class OpenAPIResponseValidator(OpenAPIValidator):
6970
def __call__(self, chain: HandlerChain, context: RequestContext, response: Response):
70-
# We are more lenient in validating the responses. The use of this flag is intended for test.
71+
# The use of this flag is intended for test only. Eventual errors are due to LocalStack implementation and not
72+
# to improper user usage of the endpoints.
7173
if not config.OPENAPI_VALIDATE_RESPONSE:
7274
return
7375

@@ -79,7 +81,7 @@ def __call__(self, chain: HandlerChain, context: RequestContext, response: Respo
7981
WerkzeugOpenAPIRequest(context.request),
8082
WerkzeugOpenAPIResponse(response),
8183
)
82-
except OpenAPIError as exc:
84+
except ResponseValidationError as exc:
8385
LOG.error("Response validation failed for %s: $s", path, exc)
8486
response.status_code = 500
8587
response.set_json({"error": exc.__class__.__name__, "message": str(exc)})

0 commit comments

Comments
 (0)
0