Validate existing test apigw #10653
Merged
Validate existing test apigw #10653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_base_64_encoded`
bentsku
approved these changes
Apr 15, 2024
Comment on lines
+1943
to
+1951
| client_config = None | ||
| if is_aws_cloud(): | ||
| client_config = botocore.config.Config( | ||
| # Api gateway can throttle requests pretty heavily. Leading to potentially undeleted apis | ||
| retries={"max_attempts": 10, "mode": "adaptive"} | ||
| ) | ||
| apigateway_client = aws_client_factory( | ||
| region_name=region_name, config=client_config | ||
| ).apigateway |
There was a problem hiding this comment.
Ah, this is a great way to fix it. We also have some other fixtures which just try deleting forever or almost if getting a 429, the throttling of DeleteRestApi is really insane to me, you'd need to add 15+ seconds sleep in between calls 😭 neat 👌
|
@bentsku I added a lost commit forgotten on my machine! It contained the update you mentioned for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of the effort to improve parity with aws. This first step sorts all
aws.unknowntags and replaces them withaws.validatedoraws.needs_fixing.Changes
Started to go through apigw