Update protocol and add SendDataRequest nonce #560

lukasIO · 2025-01-28T08:37:45Z

ilo-nanpa · 2025-01-28T08:37:48Z

theomonnom · 2025-01-28T09:55:36Z

livekit-api/src/services/room.rs

@@ -288,6 +289,8 @@ impl RoomClient {
        data: Vec<u8>,
        options: SendDataOptions,
    ) -> ServiceResult<()> {
+        let mut rng = rand::rng();
+        let nonce: Vec<u8> = (0..16).map(|_| rng.random::<u8>()).collect();


nit, you could easily avoid heap allocation
let mut nonce = [0u8; 16];

had this initially with rnd:fill(arr) but this required .to_vec() which copies everything into the vec. I guess it would still do heap allocation at the time of copying it into the vec?

ah yeah, seems unnecessary then

Update protocol and add SendDataRequest nonce

04e58b2

lukasIO requested review from typester and theomonnom January 28, 2025 08:38

theomonnom approved these changes Jan 28, 2025

View reviewed changes

theomonnom reviewed Jan 28, 2025

View reviewed changes

lukasIO added 2 commits January 28, 2025 13:50

changeset

ed3edcd

typo

5c90762

lukasIO merged commit 370d2ac into main Jan 28, 2025
6 checks passed

lukasIO deleted the lukas/data-nonce branch January 28, 2025 12:53

rileyseaburg pushed a commit to Evolving-Software/livekit-rust-sdks that referenced this pull request Feb 19, 2025

Update protocol and add SendDataRequest nonce (livekit#560)

b745f34

* Update protocol and add SendDataRequest nonce * changeset * typo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update protocol and add SendDataRequest nonce #560

Update protocol and add SendDataRequest nonce #560

Update protocol and add SendDataRequest nonce #560

Update protocol and add SendDataRequest nonce #560

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment