8000 Fix parsing stun configuration by ashellunts · Pull Request #5 · livekit/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Fix parsing stun configuration #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix parsing stun configuration #5

wants to merge 1 commit into from

Conversation

ashellunts
Copy link

Code was expecting a stun value to be under key 'url'.
I have added support for format of stun where url is just a string.

Diff is not good, because most of the code is not changed (just put inside if block).

@ashellunts
Fix parsing stun configuration
f746170 
Code was expecting a stun value to be under key 'url'
@davidzhao
Copy link
Member

@ashellunts could you submit this PR against the source repo in flutter-webrtc? 🙏

@ashellunts
Copy link
Author
ashellunts commented Dec 1, 2021 via email

@ashellunts
Copy link
Author

flutter-webrtc#789

@ashellunts
Copy link
Author

flutter-webrtc#789 is merged. Closing this PR.

@ashellunts ashellunts closed this Dec 2, 2021
@ashellunts ashellunts deleted the windows branch December 3, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashellunts @davidzhao
0