Fix parsing stun configuration #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was expecting a stun value to be under key 'url'
|
@davidzhao @cloudwebrtc Hi guys ! @ashellunts found this issue that was causing a crash on Windows. https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/urls |
|
LGTM |
cloudwebrtc
approved these changes
Dec 2, 2021
|
@cloudwebrtc can you release new version, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was expecting a stun value to be under key 'url'.
I have added support for format of stun where url is just a string.
Diff is not good, because most of the code is actually not changed (just inserted inside if block).