8000 code-server: ros2 initial release by greinet · Pull Request #538 · linuxserver/docker-mods · GitHub
[go: up one dir, main page]
Skip to content

code-server: ros2 initial release #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2023
Merged

code-server: ros2 initial release #538

merged 6 commits into from
Apr 13, 2023

Conversation

greinet
Copy link
Contributor
@greinet greinet commented Dec 12, 2022

Adds ROS2 to code-server and openvscode-server.

code-server: ros2 initial release
adef711 
Adds ROS2 to code-server and openvscode-server
@aptalca aptalca self-assigned this Dec 12, 2022
aptalca
aptalca requested changes Dec 13, 2022
View reviewed changes
Copy link
Member
@aptalca aptalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. < 8000 /p>

Thanks for the PR.

Please add the init files for s6v2 to make it hybrid and we'll merge.

And please make sure the init and run files are executable (I can't check without cloning locally as Github doesn't seem to display it anymore)

@greinet
Copy link
Contributor Author
greinet commented Dec 14, 2022

I added the s6v2 files but i don know how to test them.
As I don't know too much about s6-overlayI assume the file permissions should be okay, otherwise I can also change them:

$ tree -pufi root/etc
[drwxr-xr-x abc     ]  root/etc
[drwxr-xr-x abc     ]  root/etc/cont-init.d
[-rwxr-xr-x abc     ]  root/etc/cont-init.d/95-apt-get
[-rwxr-xr-x abc     ]  root/etc/cont-init.d/98-ros2
[drwxr-xr-x abc     ]  root/etc/s6-overlay
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package/dependencies.d
[-rw-r--r-- abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package/dependencies.d/init-mods
[-rwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package/run
[-rw-r--r-- abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package/type
[-rw-r--r-- abc     ]  root/etc/s6-overlay/s6-rc.d/init-mod-code-server-ros2-add-package/up
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/init-mods-package-install
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/init-mods-package-install/dependencies.d
[-rw-r--r-- abc     ]  root/etc/s6-overlay/s6-rc.d/init-mods-package-install/dependencies.d/init-mod-code-server-ros2-add-package
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/user
[drwxr-xr-x abc     ]  root/etc/s6-overlay/s6-rc.d/user/contents.d
[-rw-r--r-- abc     ]  root/etc/s6-overlay/s6-rc.d/user/contents.d/init-mod-code-server-ros2-add-package

aptalca
aptalca requested changes Dec 14, 2022
View reviewed changes
Copy link
Member
@aptalca aptalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perms look good, just see the comments about the repo addition and apt install in v2 script

@greinet
Copy link
Contributor Author
greinet commented Dec 15, 2022

Thanks for the detailed instructions, I moved the repo addition and changed to use apt install. The one thing I wasn't able to solve was where to put
printf "\n# Automatically source ROS2 humble\nsource /opt/ros/humble/setup.bash" >> /etc/bash.bashrc
It automatically sources ros2 so the command is available in the terminal, i guess it's not strictly needed but would be helpful to include.

@aptalca
Copy link
Member
aptalca commented Jan 2, 2023

@greinet the abc user's home folder is set to /config so the profile and bashrc should be in there

@greinet greinet requested a review from aptalca January 4, 2023 07:26
@aptalca
Copy link
Member
aptalca commented Apr 13, 2023

Apologies, I totally missed that you pushed the requested changes. I'll make some modifications to it based on our latest changes and then merge. Thanks for your patience.

@aptalca aptalca merged commit c7b1f3c into linuxserver:code-server-ros2 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptalca aptalca aptalca approved these changes

Assignees

@aptalca aptalca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greinet @aptalca
0