8000 Teach UpdateLibgit2ToSha.ps1 to copy native binaries on windows only by nulltoken · Pull Request #973 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Teach UpdateLibgit2ToSha.ps1 to copy native binaries on windows only #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2015
Merged

Teach UpdateLibgit2ToSha.ps1 to copy native binaries on windows only #973

merged 1 commit into from
Feb 21, 2015

Conversation

nulltoken
Copy link
Member

No description provided.

@nu 8000 lltoken
Copy link
Member Author

Now that #972 is merged. Let's make sure the next time we update the libgit2 binaries we propagate the change.

/cc @bording Thoughts? I hope I didn't mess anything.

@nulltoken nulltoken added this to the v0.22 milestone Feb 21, 2015
Therzok
Therzok reviewed Feb 21, 2015
View reviewed changes
UpdateLibgit2ToSha.ps1
@@ -184,7 +184,7 @@ namespace LibGit2Sharp.Core
$buildProperties = @"
<?xml version="1.0" encoding="utf-8"?>
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<ItemGroup Condition=" '`$(OS)' == 'Windows_NT' ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with that backtick?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've understood, it's a way to prevent Powershell from evaluating the $() expression (Disclaimer: I'm not a PowerShell expert).

Cf: https://technet.microsoft.com/en-us/library/hh847740.aspx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it looks good to me. :)

@bording
Copy link
Member
bording commented Feb 21, 2015

Hah, I completely missed that the props file was generated by that powershell script, or I would have updated that too! Still getting to know my way around the code base!

That change looks good to me!

👍

@nulltoken nulltoken merged commit a0776fa into vNext Feb 21, 2015
@nulltoken nulltoken deleted the ntk/props branch February 21, 2015 21:12
@nulltoken
Copy link
Member Author

@Therzok @bording Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22
Development

Successfully merging this pull request may close these issues.
3 participants
@nulltoken @bording @Therzok
0