8000 Make NuGet package copy native binaries on windows only by bording · Pull Request #972 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Make NuGet package copy native binaries on windows only #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2015
Merged

Make NuGet package copy native binaries on windows only #972

merged 1 commit into from
Feb 21, 2015

Conversation

bording
Copy link
Member
@bording bording commented Feb 21, 2015

The props file added to the NuGet package in #821 makes sure the Windows native binaries are copied to the correct location. However, as pointed out in #835, this now happens even when the package is installed on a non-Windows platform.

This can be prevented by adding a condition to the imported ItemGroup that makes it be ignored when running on a non-Windows platform.

I've tested this change in Visual Studio and Xamarin Studio on OS X.

@bording
Make NuGet package copy native binaries on windows only
caded6e 
The props file added to the NuGet package in #821 makes sure the Windows
native binaries are copied to the correct location. However, as pointed out
in #835, this now happens even when the package is installed on a non-Windows
platform.

This can be prevented by adding a condition to the imported ItemGroup that
makes it be ignored when running on a non-Windows platform.

Closes #835
@nulltoken nulltoken merged commit caded6e into libgit2:vNext Feb 21, 2015
@nulltoken nulltoken added this to the v0.22 milestone Feb 21, 2015
@nulltoken
Copy link
Member

Neat!!!! 👍

@nulltoken nulltoken mentioned this pull request Feb 21, 2015
Merged
@bording bording deleted the nugetNonWindowsTweak branch February 21, 2015 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22
Development

Successfully merging this pull request may close these issues.
2 participants
@bording @nulltoken
0