Adding support for message formatting in exception c'tors #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I packed up that commit incorrectly while tying to undo the auto-formatting mess VS keeps getting me into. Let me see what I did there 😖 |
|
Nope - it actually looks like the NRE issue come back to haunt me. 😢 |
Restarted the build |
| @@ -210,11 +210,13 @@ public virtual ContentChanges Compare(Blob oldBlob, Blob newBlob, CompareOptions | |||
| { | |||
| Func<DiffSafeHandle, object> builder; | |||
|
|
|||
| if (!ChangesBuilders.TryGetValue(typeof (T), out builder)) | |||
There was a problem hiding this comment.
Any chance you could move the beautifications in a separate commit?
There was a problem hiding this comment.
@#$%! I thought I got that all cleaned up 🐼
|
I really like this proposal! |
nulltoken
added a commit
that referenced
this pull request
Jun 16, 2015
Adding support for message formatting in exception c'tors
|
✨ ✨ ✨ ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just simplifies the code. There's not a great reason to continually use
string.Format(...)constantly.Was limited to using the
public LibGit2SharpException(CultureInfo cultureInfo, string format, params object[] args)to avoid a conflict with thepublic LibGit2SharpException(string message, Exception innerException)if I usedpublic LibGit2SharpException(string format, params object[] args).