8000 Deploy usage of support for message formatting in exception c'tors · Issue #1098 · libgit2/libgit2sharp · GitHub
[go: up one dir, main page]
Skip to content

Deploy usage of support for message formatting in exception c'tors #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nulltoken opened this issue Jun 16, 2015 · 1 comment
Closed

Deploy usage of support for message formatting in exception c'tors #1098

nulltoken opened this issue Jun 16, 2015 · 1 comment
Labels
Easy fix Up for grabs
Milestone
v0.22

Comments

@nulltoken
Copy link
Member

While reviewing #1097, it looks like many throws do not actually leverage what #1095 brought.

🔥 Let's get rid of those pesky string.Format() calls

/cc @whoisj
rooflz added a commit to rooflz/libgit2sharp that referenced this issue Oct 4, 2015
@rooflz
libgit2#1098 Deploy usage of support for message formatting in except…
c667ece 
…ion c'tors

Reviewed usages of LibGit2SharpException and removed any unnecessary
string.format calls.
nulltoken added a commit that referenced this issue Oct 4, 2015
@nulltoken
Merge pull request #1198 from rooflz/vNext
ac4c7d9 
#1098 Deploy usage of support for message formatting in exception c'tors
@nulltoken nulltoken added this to the v0.22 milestone Oct 4, 2015
@whoisj
Copy link
whoisj commented Oct 5, 2015

Awesome to see this one closed. Apologies for not having had time to address it myself.

Thanks @rooflz ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy fix Up for grabs
Projects
None yet
Milestone
v0.22
Development

No branches or pull requests
2 participants
@nulltoken @whoisj
0