8000 transport: do not filter tags based on ref dir in local by rindeal · Pull Request #6881 · libgit2/libgit2 · GitHub
[go: up one dir, main page]
Skip to content

transport: do not filter tags based on ref dir in local #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

transport: do not filter tags based on ref dir in local #6881

merged 1 commit into from
Sep 27, 2024

Conversation

rindeal
Copy link
Contributor
@rindeal rindeal commented Sep 12, 2024 •
edited
Loading

Let git_object_type() do the filtering instead.

Fixes: #6275

@ethomson
Copy link
Member

Hi @rindeal! This seems like it makes sense! The tests are failing, though - are the tests wrong (and should have been reporting these refs in the first place?) or is the implementation not quite right?

8000
@rindeal
transport: do not filter tags based on ref dir in local
656e751 
Let git_object_type() do the filtering instead.

Fixes: libgit2#6275
@rindeal
Copy link
Contributor Author
rindeal commented Sep 25, 2024

Hi @rindeal! This seems like it makes sense! The tests are failing, though - are the tests wrong (and should have been reporting these refs in the first place?) or is the implementation not quite right?

As detailed in the linked issue, the function wasn't peeling refs/blobs/annotated_tag_to_blob, resulting in the output being one line shorter. I've updated the tests so all should be well now.

@ethomson
Copy link
Member

As detailed in the linked issue, the function wasn't peeling refs/blobs/annotated_tag_to_blob, resulting in the output being one line shorter. I've updated the tests so all should be well now.

Ah, thanks, I think that I may have noticed that in my initial review and forgotten when I came back to this. In any case, very cool, thanks for the fix.

@ethomson ethomson merged commit d823103 into libgit2:main Sep 27, 2024
19 checks passed
@rindeal rindeal deleted the rindeal-patch-1 branch September 27, 2024 14:40
@ethomson ethomson added the bug label Sep 29, 2024
@BrewTestBot Br 6932 ewTestBot mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difference in behaviour between git ls-remote and libgit2 equivalent
2 participants
@rindeal @ethomson
0