transport: do not filter tags based on ref dir in local

rindeal · rindeal · commit 656e75147ac2 · 2024-09-25T14:45:41.000Z
Let git_object_type() do the filtering instead. Fixes: #6275
diff --git a/src/libgit2/transports/local.c b/src/libgit2/transports/local.c
@@ -108,10 +108,6 @@ static int add_ref(transport_local *t, const char *name)
 		return error;
 	}
 
-	/* If it's not a tag, we don't need to try to peel it */
-	if (git__prefixcmp(name, GIT_REFS_TAGS_DIR))
-		return 0;
-
 	if ((error = git_object_lookup(&obj, t->repo, &head->oid, GIT_OBJECT_ANY)) < 0)
 		return error;
 
diff --git a/tests/libgit2/network/remote/local.c b/tests/libgit2/network/remote/local.c
@@ -61,7 +61,7 @@ void test_network_remote_local__retrieve_advertised_references(void)
 
 	cl_git_pass(git_remote_ls(&refs, &refs_len, remote));
 
-	cl_assert_equal_i(refs_len, 30);
+	cl_assert_equal_i(refs_len, 31);
 }
 
 void test_network_remote_local__retrieve_advertised_before_connect(void)
@@ -85,7 +85,7 @@ void test_network_remote_local__retrieve_advertised_references_after_disconnect(
 
 	cl_git_pass(git_remote_ls(&refs, &refs_len, remote));
 
-	cl_assert_equal_i(refs_len, 30);
+	cl_assert_equal_i(refs_len, 31);
 }
 
 void test_network_remote_local__retrieve_advertised_references_from_spaced_repository(void)
@@ -100,7 +100,7 @@ void test_network_remote_local__retrieve_advertised_references_from_spaced_repos
 
 	cl_git_pass(git_remote_ls(&refs, &refs_len, remote));
 
-	cl_assert_equal_i(refs_len, 30);
+	cl_assert_equal_i(refs_len, 31);
 
 	git_remote_free(remote);	/* Disconnect from the "spaced repo" before the cleanup */
 	remote = NULL;

Original file line number	Diff line number	Diff line change
`@@ -108,10 +108,6 @@ static int add_ref(transport_local t, const char name)`
`108`	`108`	`return error;`
`109`	`109`	`}`
`110`	`110`
`111`		`- /* If it's not a tag, we don't need to try to peel it */`
`112`		`- if (git__prefixcmp(name, GIT_REFS_TAGS_DIR))`
`113`		`- return 0;`
`114`		`-`
`115`	`111`	`if ((error = git_object_lookup(&obj, t->repo, &head->oid, GIT_OBJECT_ANY)) < 0)`
`116`	`112`	`return error;`
`117`	`113`