Add close method to websocket client #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0bf814 to
94861c7
Compare
mrmcmuffinz
reviewed
Feb 27, 2017
| """ | ||
| close websocket connection. | ||
| """ | ||
| self._connected = False |
There was a problem hiding this comment.
Should we check that the socket is open before closing it?
There was a problem hiding this comment.
close method is safe to call even if the socket is closed.
| @@ -191,6 +191,14 @@ def run_forever(self, timeout=None): | |||
| while self.is_open(): | |||
| self.update(timeout=None) | |||
|
|
|||
| def close(self, **kwargs): | |||
There was a problem hiding this comment.
What are some of the variable arguments you envision being used here? Just trying to get a feel for this change...
There was a problem hiding this comment.
Also, just out of curiosity, should we return True/False if we were able to close successfully the socket?
There was a problem hiding this comment.
Look at WebScoket close method for more information: https://github.com/websocket-client/websocket-client/blob/master/websocket/_core.py#L372
that method does not return any status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #145