Merge pull request #146 from mbohlool/closemethod

mbohlool · web-flow · commit dc35eee071fd · 2017-02-28T11:25:01.000-08:00
Add close method to websocket client
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # v1.0.1
 - Bugfix: blocking exec call should remove channel metadata #140
+- Add close method to websocket api of interactive exec #145
 
 # v1.0.0b3
 - Bugfix: Missing websocket-client dependency #131
diff --git a/examples/exec.py b/examples/exec.py
@@ -92,3 +92,4 @@
 resp.write_stdin("whoami\n")
 user = resp.readline_stdout(timeout=3)
 print("Server user is: %s" % user)
+resp.close()
diff --git a/kubernetes/client/ws_client.py b/kubernetes/client/ws_client.py
@@ -191,6 +191,14 @@ def run_forever(self, timeout=None):
             while self.is_open():
                 self.update(timeout=None)
 
+    def close(self, **kwargs):
+        """
+        close websocket connection.
+        """
+        self._connected = False
+        if self.sock:
+            self.sock.close(**kwargs)
+
 
 WSResponse = collections.namedtuple('WSResponse', ['data'])
 
