8000 Remove conformance test calls to `/` by liggitt · Pull Request #122129 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Remove conformance test calls to / #122129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2023
Merged

Remove conformance test calls to / #122129

merged 2 commits into from
Nov 30, 2023

Conversation

liggitt
Copy link
Member
@liggitt liggitt commented Nov 30, 2023

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Reverts the unconsidered conformance test change in 0cda42a, moves the functional test validating the APIService cleanup to an integration test

Which issue(s) this PR fixes:

Fixes #121985

Does this PR introduce a user-facing change?

NONE

/sig architecture api-machinery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Nov 30, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Nov 30 16:05:39 UTC 2023.

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2023
This was referenced Nov 30, 2023
Closed
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
8000

@k8s-ci-robot k8s-ci-robot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 30, 2023
@liggitt
Copy link
Member Author
liggitt commented Nov 30, 2023

/assign @sttts

as approver of #121283

@liggitt
Copy link
Member Author
liggitt commented Nov 30, 2023

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 30, 2023
@deads2k
Copy link
Contributor
deads2k commented Nov 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e40be57071bb1ad648c4fbafc080eda9f91d1712

@BenTheElder
Copy link
Member

/triage accepted
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 55f2bc1 into kubernetes:master Nov 30, 2023
@sttts
Copy link
Contributor
sttts commented Nov 30, 2023

Lgtm.

@tnqn tnqn mentioned this pull request Dec 1, 2023
Closed
@liggitt liggitt deleted the root-conformance branch July 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sttts sttts

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Running conformance test on 1.29.0-alpha.3 cluster with sonobuoy fails
5 participants
@liggitt @k8s-ci-robot @deads2k @BenTheElder @sttts
0