8000 e2e: skip checking the removal of group path if not permitted by tnqn · Pull Request #121986 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

e2e: skip checking the removal of group path if not permitted #121986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

e2e: skip checking the removal of group path if not permitted #121986

wants to merge 1 commit into from

Conversation

tnqn
Copy link
Member
@tnqn tnqn commented Nov 21, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

#121283 added the check of the removal of the group path to an e2e test. However, test runners like sonobuoy may not have the permission to read the root path. Skip checking the removal of the group path in that case.

With the patch, the test can succeed when running with sonobuoy:

  STEP: APIService deleteCollection with labelSelector: "v1alpha1.wardle.example.com=updated" @ 11/21/23 15:47:
8000
34.394
  STEP: Confirm that the generated APIService has been deleted @ 11/21/23 15:47:34.408
  Nov 21 15:47:34.408: INFO: Requesting list of APIServices to confirm quantity
  Nov 21 15:47:34.414: INFO: Found 0 APIService with label "v1alpha1.wardle.example.com=updated"
  Nov 21 15:47:34.414: INFO: APIService v1alpha1.wardle.example.com has been deleted.
  STEP: Confirm that the group path of v1alpha1.wardle.example.com was removed from root paths @ 11/21/23 15:47:34.415
  Nov 21 15:47:34.417: INFO: Skip checking the removal of the group path due to lack of permission of reading the root path
  Nov 21 15:47:34.484: INFO: Waiting up to 7m0s for all (but 0) nodes to be ready
  STEP: Destroying namespace "aggregator-9018" for this suite. @ 11/21/23 15:47:34.488

Which issue(s) this PR fixes:

Fixes #121985

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@tnqn
e2e: skip checking the removal of group path if not permitted
111e4ec 
Test runners like sonobuoy may not have the permission to read the root
path. Skip checking the removal of the group path in that case.

Signed-off-by: Quan Tian <qtian@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnqn
Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2023
@tnqn tnqn mentioned this pull request Nov 21, 2023
Closed
@tnqn
Copy link
Member Author
tnqn commented Nov 21, 2023

cc @rtheis @sttts @Jefftree

@k8s-ci-robot
Copy link
Contributor

@tnqn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration 111e4ec link true /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

BenTheElder
BenTheElder reviewed Nov 21, 2023
View reviewed changes
test/e2e/apimachinery/aggregator.go
SetHeader("Accept", "application/json").DoRaw(ctx)
if err != nil {
if apierrors.IsForbidden(err) {
framework.Logf("Skip checking the removal of the group path due to lack of permission of reading the root path")
Copy link
< 8000 /details-menu>
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conformance tests may not skip.
the whole point of conformance tests is to be required of all clusters.

/hold

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed we should not skip. I opened #122129 as an alternative that reverts the conformance change and validates the bugfix in an integration test instead

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@tnqn tnqn mentioned this pull request Nov 22, 2023
Closed
@jiahuif
Copy link
Contributor
jiahuif commented Nov 28, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 28, 2023
@liggitt
Copy link
Member
liggitt commented Nov 30, 2023

/close

alternative fixes discussed in #121985 (comment)

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

alternative fixes discussed in #121985 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnqn tnqn deleted the fix-e2e branch December 1, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@liggitt liggitt liggitt left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

No one assigned

Labels

area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Running conformance test on 1.29.0-alpha.3 cluster with sonobuoy fails

5 participants

@tnqn @k8s-ci-robot @jiahuif @liggitt @BenTheElder
0