8000 Import ABC from collections.abc for Python 3.9 compatibility by tirkarthi · Pull Request #330 · kkroening/ffmpeg-python · GitHub
[go: up one dir, main page]
Skip to content

Import ABC from collections.abc for Python 3.9 compatibility #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2022
Merged

Import ABC from collections.abc for Python 3.9 compatibility #330

merged 5 commits into from
Mar 7, 2022

Conversation

tirkarthi
Copy link
Contributor

Fixes #325 #326

@tirkarthi tirkarthi requested a review from kkroening February 15, 2020 14:51
vifly added a commit to vifly/arch-build that referenced this pull request Dec 15, 2021
@vifly
remove python-ffmpeg
62c703c 
The upstream didn't merge kkroening/ffmpeg-python#330
@desbma desbma mentioned this pull request Dec 22, 2021
Closed
kkroening added a commit that referenced this pull request Mar 6, 2022
@kkroening
Use GitHub Actions for CI.
e892dd3 
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.
@kkroening kkroening mentioned this pull request Mar 6, 2022
Merged
kkroening added a commit that referenced this pull request Mar 6, 2022
@kkroening
Use GitHub Actions for CI.
697d1c2 
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.
kkroening added a commit that referenced this pull request Mar 6, 2022
@kkroening
Use GitHub Actions for CI.
1cbd2cd 
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.
kkroening added a commit that referenced this pull request Mar 6, 2022
@kkroening
Use GitHub Actions for CI.
b76f493 
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.
kkroening added a commit that referenced this pull request Mar 7, 2022
@kkroening
Use GitHub Actions for CI. (#641)
29b6f09 
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.

Co-authored by: Christian Clauss <cclauss@me.com>
@kkroening
Copy link
Owner

Looks good! Thanks for the fixes.

@kkroening kkroening merged commit 6189cd6 into kkroening:master Mar 7, 2022
This was referenced Mar 7, 2022
Closed
Closed
@tirkarthi
Copy link
Contributor Author

Thanks @kkroening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkroening kkroening Awaiting requested review from kkroening

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections was deprecated since Python 3.4 and removed in Python 3.9
2 participants
@tirkarthi @kkroening
0