8000 Use GitHub Actions for CI by kkroening · Pull Request #641 · kkroening/ffmpeg-python · GitHub
[go: up one dir, main page]

Skip to content

Use GitHub Actions for CI #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Use GitHub Actions for CI #641

merged 1 commit into from
Mar 7, 2022

Conversation

kkroening
Copy link
Owner

This sets up GitHub Actions (GHA) to run in place of the currently broken Travis CI. Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint, mypy, flake8, etc. - see #605, for example.

Notes:

  • Python 3.10 is not yet supported due to the collections.Iterable issue discussed in Import ABC from collections.abc for Python 3.9 compatibility #330, use collections.abc.Iterable #624, etc.
  • The Black CI step acts as a linting step, rather than attempting to have the GHA job automatically update/commit/push the reformarted code.
  • Black is currently pinned to an older version that supports --target-version py27 until Python 2 compatibility can be dropped in the final Python 2 compatibility release of ffmpeg-python.
  • Only the main source directory (ffmpeg/) is checked with Black at the moment. The examples/ directory should also be checked, but will be done as a separate PR.

@kkroening kkroening force-pushed the KK/gha branch 2 times, most recently from 697d1c2 to 1cbd2cd Compare March 6, 2022 23:20
This sets up GitHub Actions (GHA) to run in place of the
currently broken Travis CI.  Initially, this only covers running
tox/pytest and Black, but may eventually be extended to run pylint,
mypy, flake8, etc. - see #605, for example.

Notes:
* Python 3.10 is not yet supported due to the `collections.Iterable`
  issue discussed in #330, #624, etc.
* The Black CI step acts as a linting step, rather than attempting to
  have the GHA job automatically update/commit/push the reformarted
  code.
* Black is currently pinned to an older version that supports
  `--target-version py27` until Python 2 compatibility can be dropped in
  the final Python 2 compatibility release of ffmpeg-python.
* Only the main source directory (`ffmpeg/`) is checked with Black at
  the moment.  The `examples/` directory should also be checked, but
  will be done as a separate PR.
@kkroening kkroening merged commit 29b6f09 into master Mar 7, 2022
@kkroening kkroening deleted the KK/gha branch March 7, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0