Fix LDSHARED and missing CFLAGS include path for python3crystax sources #1361
Conversation
|
Thanks, you're a machine! 😂 |
|
@AndreMiras I really need python-for-android for my app, so it is worth it for me to sink some time into getting things fixed. 👍 I just tested this with my actual real world app which is python3crystax and uses the recipes Pillow and pysdl2, and some other pure python dependencies. For this app, this pull request builds & runs fine. |
|
OK good stuff. However it seems to break the Python2 builds 😕 yes I know it's a nightmare. You can view the complete error clicking on the "Raw logs" button, e.g. https://api.travis-ci.org/v3/job/425450654/log.txt Yes sometimes simple change break unsuspected things. I also don't see yet the relation between your changes and the way the build broke, but that's quite usual in p4a 😛 Edit: oh that might be that trailing quote after |
|
Yeah, interesting, it definitely didn't fail for me for some reason. Anyway, I fixed the trailing comma now. Let's see if that improves things |
|
Is there something you have in mind I could test? Or how do we go about making a test branch with the recipes adapted accordingly so we can find out if this works for them? |
|
No, it's looking good, I do think it works. I had more concern regarding if it should be done that way. I'll discuss briefly with other devs on IRC and if it's OK we'll merge. |
Since kivy/python-for-android#1361 was merged upstream, some `LDSHARED` and `CFLAGS` could be cleaned.
Since kivy#1361 was merged, we can drop LDSHARED override.
Since kivy#1361 was merged, we can drop LDSHARED override. Also pined `secp256k1-py` version and couple of other fixes.
As proposed in #1360 this change fixes
env["LDSHARED"]not being set which can confuse distutils /python setup.py build_extto use the incorrect host compiler, and it adds the-Ifolder to the python3 crystax sources when using python 3 crystax. This should allow a lot of recipes to be cleaned up later which currently have the same repeated hacks to work around this. (Uncleaned recipes should just duplicate include paths which should do no harm, so this shouldn't require any recipes to be changed to be safely merged)Testing state:
Pillowrecipe)