Closed
Description
LDSHARED doesn't seem to be set in PythonRecipe leading to failing compilation in some scenarios.
The compilation may be failing because p4a would then pick up the system linker rather than the cross-compiler one.
For this reasons some recipes added that change in their get_recipe_env() method, like below:
env['LDSHARED'] = env['CC'] + ' -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions'As in last master commit 0dc7664 we have at least 17 of them:
$ grep -r "env\['LDSHARED'\] = env\['CC'\]" pythonforandroid/recipes/ | wc -l
17
In his PR JonasT tries to address it via pythonforandroid/archs.py, see https://github.com/kivy/python-for-android/pull/1357/files#diff-569e13021e33ced8b54385f55b49cbe6R115
This probably requires investigation to know where is the proper place to put it and then the pull request fixing it should also clean recipes overriding it in their get_recipe_env() method.
Metadata
Metadata
Assignees
Labels
No labels