Add Hero Devs support #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- styles for the new download button are in jquery/jquery-wp-content#468 Ref jquery/jquery-wp-content#462 Ref jquerygh-245 Closes jquerygh-243 Co-authored-by: Andre Angelantoni <andre@herodevs.com>
This was referenced Sep 30, 2024
Krinkle
reviewed
Oct 1, 2024
Krinkle
reviewed
Oct 1, 2024
|
looks good to us, can @timmywil make these adjustments? Or would you like Andre to recreate the PR's from scratch? |
|
I can do that. |
- address PR feedback; additional wording changes - add some upgrade instructions to the upgrade guide index
|
I made some content changes that I think address the comments. Also, I've added some context and general upgrade instructions to the upgrade guide index page, which was previously just a list of links. |
mgol
reviewed
Oct 6, 2024
There was a problem hiding this comment.
A few comments, plus this depends on where we end up with jquery/jquery-wp-content#468.
A dedicated support page will definitely be helpful!
Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
mgol
approved these changes
Oct 11, 2024
timmywil
added a commit
to jquery/api.jquery.com
that referenced
this pull request
Oct 13, 2024
timmywil
added a commit
to jquery/infrastructure-puppet
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jquery/jquery-wp-content#462
Ref #245
Closes #243