8000 [release-1.9] Time.tickers that are no longer in use should be closed by istio-testing · Pull Request #34200 · istio/istio · GitHub
[go: up one dir, main page]
Skip to content

[release-1.9] Time.tickers that are no longer in use should be closed #34200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

[release-1.9] Time.tickers that are no longer in use should be closed #34200

merged 1 commit into from
Jul 23, 2021

Conversation

@istio-testing
Copy link
Collaborator
@istio-testing istio-testing commented Jul 21, 2021

This is an automated cherry-pick of #34133

@ChenglongGao327 @istio-testing
Time.tickers that are no longer in use should be closed
7dd89cb 
1. if time.ticker no longer in use ,stop it
@istio-testing istio-testing requested a review from a team July 21, 2021 03:08
@istio-testing istio-testing mentioned this pull request Jul 21, 2021
Merged
@istio-testing istio-testing added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. labels Jul 21, 2021
@google-cla
Copy link
google-cla bot commented Jul 21, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@google-cla google-cla bot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Jul 21, 2021
@jacob-delgado
Copy link
Contributor
jacob-delgado commented Jul 21, 2021

cc @ChenglongGao327 can you please cherry pick and fix this in the release 1.9 branch? Thanks.

@ChenglongGao327
Copy link
Member
ChenglongGao327 commented Jul 22, 2021

@googlebot I consent

@google-cla google-cla bot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jul 22, 2021
@jacob-delgado
Copy link
Contributor
jacob-delgado commented Jul 23, 2021

/retest

@istio-testing istio-testing merged commit 579f7dc into istio:release-1.9 Jul 23, 2021
libesz pushed a commit to libesz/istio that referenced this pull request Nov 11, 2021
@istio-testing @ChenglongGao327
Time.tickers that are no longer in use should be closed (istio#34200)
e8ccf87 
1. if time.ticker no longer in use ,stop it

Co-authored-by: Chenglong Gao <gaochenglong@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-delgado jacob-delgado jacob-delgado approved these changes

Assignees

@ChenglongGao327 ChenglongGao327

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@istio-testing @jacob-delgado @ChenglongGao327
0