Time.tickers that are no longer in use should be closed (istio#34200)

istio-testing · ChenglongGao327 · shamsher31 · commit e8ccf87e71c2 · 2021-08-26T14:58:19.000+05:30
1. if time.ticker no longer in use ,stop it

Co-authored-by: Chenglong Gao &lt;gaochenglong@huawei.com&gt;
diff --git a/pkg/istio-agent/health/health_check.go b/pkg/istio-agent/health/health_check.go
@@ -170,6 +170,7 @@ func (w *WorkloadHealthChecker) PerformApplicationHealthCheck(callback func(*Pro
 	// Send the first request immediately
 	doCheck()
 	periodTicker := time.NewTicker(w.config.CheckFrequency)
+	defer periodTicker.Stop()
 	for {
 		select {
 		case <-quit:
diff --git a/security/pkg/pki/ca/ca.go b/security/pkg/pki/ca/ca.go
@@ -101,6 +101,7 @@ func NewSelfSignedIstioCAOptions(ctx context.Context,
 	if scrtErr != nil && readCertRetryInterval > time.Duration(0) {
 		pkiCaLog.Infof("Citadel in signing key/cert read only mode. Wait until secret %s:%s can be loaded...", namespace, CASecret)
 		ticker := time.NewTicker(readCertRetryInterval)
+		defer ticker.Stop()
 		for scrtErr != nil {
 			select {
 			case <-ticker.C:
