8000 Add tests for join and unjoin service calls in Sonos by PeteRager · Pull Request #145602 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add tests for join and unjoin service calls in Sonos #145602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Add tests for join and unjoin service calls in Sonos #145602

wants to merge 10 commits into from
+221 −53

Conversation

PeteRager
Copy link
Contributor
@PeteRager PeteRager commented May 25, 2025 •
edited
Loading

Proposed change

Improve test coverage for media_player.join and add test coverage for media_player.unjoin in the Sonos Integration.

  • Replace mocking of the integration in existing test with mocking of the API.
  • Remove mocking / access to hass.data in existing test.
  • Fix the warning message on join/unjoin timeout to contain correct information.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@PeteRager PeteRager requested a review from jjlawren as a code owner May 25, 2025 23:18
@home-assistant
Copy link

Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration (sonos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sonos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sonos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

PeteRager
PeteRager commented May 25, 2025
View reviewed changes
tests/components/sonos/conftest.py
variables["zone_player_uui_ds_in_group"] = f"{soco_1.uid},{soco_2.uid}"
uui_ds = f"{soco_1.uid},{soco_2.uid}" if create_uui_ds else None
return SonosMockEvent(soco_1, soco_1.zoneGroupTopology, variables, uui_ds)

Copy link
Contributor Author
@PeteRager PeteRager May 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This existing function was moved from test_speakers.py to conftest.py for re-use in the new tests and then made compliant with current lint testing.

@PeteRager PeteRager mentioned this pull request May 25, 2025
Draft
19 tasks
erwindouna
erwindouna suggested changes May 26, 2025
View reviewed changes
erwindouna
erwindouna approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor
@erwindouna erwindouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @PeteRager!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwindouna erwindouna erwindouna approved these changes

@jjlawren jjlawren Awaiting requested review from jjlawren jjlawren is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jjlawren jjlawren

Labels
by-code-owner cla-signed code-quality has-tests integration: sonos Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeteRager @erwindouna @jjlawren
0