Add quality scale for Sonos #144928
Add quality scale for Sonos #144928
Conversation
|
Hey there @jjlawren, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| status: exempt | ||
| comment: | | ||
| No authentication | ||
| test-coverage: todo |
There was a problem hiding this comment.
Some tests are using internals
There was a problem hiding this comment.
Yes. That needs to be fixed.
There was a problem hiding this comment.
for test_init.py - #147063
| status: exempt | ||
| comment: | | ||
| No authentication | ||
| test-coverage: todo |
There was a problem hiding this comment.
test_play_media_library ideally we don't have if statements in the tests
| status: exempt | ||
| comment: | | ||
| No authentication | ||
| test-coverage: todo |
There was a problem hiding this comment.
For some reason test_sensor is testing both binary sensor and sensor
There was a problem hiding this comment.
we can break it apart
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a quality scale definition for the Sonos integration and enables hassfest checks by removing it from the skip list.
- Removed
sonosfrom the skip list inscript/hassfest/quality_scale.py - Added
quality_scale.yamlunderhomeassistant/components/sonos/with rule statuses and exemptions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| script/hassfest/quality_scale.py | Removed "sonos" from the skip list |
| homeassistant/components/sonos/quality_scale.yaml | Added Sonos quality_scale.yaml with rules |
Comments suppressed due to low confidence (1)
homeassistant/components/sonos/quality_scale.yaml:73
- [nitpick] Add a blank line before the
# Platinumsection header to visually separate it from the Gold section and improve readability.
# Platinum
Proposed change
Add quality_scale.yaml for Sonos to assess current state (not bronze.) And to help prioritize work to get it to bronze.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: