8000 Add device_state for washer's conditional control by LG-ThinQ-Integration · Pull Request #140851 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add devic 8000 e_state for washer's conditional control #140851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Add device_state for washer's conditional control #140851

wants to merge 5 commits into from
+86 −28

Conversation

LG-ThinQ-Integration
Copy link
Contributor
@LG-ThinQ-Integration LG-ThinQ-Integration commented Mar 18, 2025 •
edited
Loading

Proposed change

  • Improve washing machine control by separating operations into switches and buttons depending on it's device_state. (washer, dryer, dishwasher, styler, etc, 9 types of devices)

  • The number, select, switch entities's control depend on it's device_state

  1. Command not supported in power off.
  2. Command not supported in remote off.
  3. Command not supported in abnormal state.
  4. Remote power on is not supported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review March 18, 2025 06:29
@LG-ThinQ-Integration
Copy link
Contributor Author

Please review this dependency commit first.

Taraman17
8000
Taraman17 reviewed Mar 20, 2025
View reviewed changes
Taraman17
Taraman17 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor
@Taraman17 Taraman17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

bieniu
bieniu reviewed Mar 28, 2025
View reviewed changes
@Giogio-2011
Copy link

is there a way to select the startup program?

@LG-ThinQ-Integration
Copy link
Contributor Author

@Giogio-2011
Please inform your washing machine type in more detail.

is there a way to select the startup program?

@Giogio-2011
Copy link

Device info:
A_F___W.B32QEUK (DEVICE_WASHER)
by LGE

From HA I can't select program (default machine start with cotton program) even by selecting a different program before activating the remote start. When the machine goes into sleep mode the setting program is lost, even in the ThinQ app.

@LG-ThinQ-Integration LG-ThinQ-Integration mentioned this pull request Apr 7, 2025
Draft
19 tasks
@LG-ThinQ-Integration
Copy link
Contributor Author

Additional button PR is #140850.

@frenck frenck added the bugfix label Apr 22, 2025
joostlek
joostlek reviewed Apr 30, 2025
View reviewed changes
@joostlek
Copy link
Member
joostlek commented May 9, 2025

So if someone has remote control turned off, can the operation and delayed start still be present? Because in that case I would not disable them, but rather have them enabled and tell the user that they can't change it because remote control is turned off

@joostlek joostlek marked this pull request as draft May 9, 2025 11:25
@LG-ThinQ-Integration
Copy link
Contributor Author

@joostlek
I modified it to send a ServiceValidationError when controlling as you suggested.

So if someone has remote control turned off, can the operation and delayed start still be present? Because in that case I would not disable them, but rather have them enabled and tell the user that they can't change it because remote control is turned off

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review May 28, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bieniu bieniu bieniu left review comments

@joostlek joostlek joostlek left review comments

@Taraman17 Taraman17 Taraman17 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: lg_thinq Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LG-ThinQ-Integration @Giogio-2011 @joostlek @bieniu @Taraman17 @frenck @edenhaus @YunseonPark-LGE
0