8000 Add button for washer's start, pause control by LG-ThinQ-Integration · Pull Request #140850 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add button for washer's start, pause control #140850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Add button for washer's start, pause control #140850

wants to merge 4 commits into from
+237 −0

Conversation

LG-ThinQ-Integration
Copy link
Contributor
@LG-ThinQ-Integration LG-ThinQ-Integration commented Mar 18, 2025 •
edited
Loading

Proposed change

  1. Improve washing machine control by separating operations into switches and buttons depending on it's device_state. (washer, dryer, dishwasher, styler, etc, 9 types of devices)
  • enable / disable : depend on device_state's device_is_on and remote_control_enabled and proper state
  • power_off or remote_control_disabled
    washer_remote_off
  • power_on and remote_control_enabled
    washer_remote_on

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@YunseonPark-LGE YunseonPark-LGE force-pushed the pr_washer_button_25.03 branch from 40f5fa1 to 9622235 Compare March 18, 2025 06:12
@LG-ThinQ-Integration
Copy link
Contributor Author

This PR has a dependency on #140851 regarding device_state.

@LG-ThinQ-Integration LG-ThinQ-Integration marked this pull request as ready for review April 7, 2025 02:46
@LG-ThinQ-Integration LG-ThinQ-Integration mentioned this pull request Apr 7, 2025
Open
19 tasks
NoRi2909

This comment was marked as resolved.

Sign in to view

joostlek
joostlek requested changes May 9, 2025
View reviewed changes
Copy link
Member
@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy is failing. Generally we also like something to be available and explain the user why they can't do the action if they try to do it. Let me double check if this is the case here as well

@home-assistant
Copy link
home-assistant bot commented May 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 9, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoRi2909 NoRi2909 NoRi2909 left review comments

@joostlek joostlek joostlek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: lg_thinq new-feature new-platform Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LG-ThinQ-Integration @joostlek @NoRi2909 @YunseonPark-LGE
0