8000 Add start mowing and dock intents for lawn mower by piitaya · Pull Request #140525 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add start mowing and dock intents for lawn mower #140525 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add start mowing and dock intents for lawn mower #140525

wants to merge 1 commit into from
+138 −0

Conversation

piitaya
Copy link
Member
@piitaya piitaya commented Mar 13, 2025

Proposed change

Add start and docker intents for lawn mower. Supported feature are the same as the vacuum domain.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:
@piitaya piitaya requested a review from a team as a code owner March 13, 2025 15:34
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (lawn_mower) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lawn_mower can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lawn_mower Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@piitaya piitaya changed the title Add start and docker intents for lawn mower Add start mowing and dock intents for lawn mower Mar 13, 2025
@piitaya piitaya mentioned this pull request Mar 13, 2025
Open
edurenye
edurenye suggested changes Apr 1, 2025
View reviewed changes
Copy link
@edurenye edurenye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these intents to Home Assistant! ❤️

IMHO, the names be more consistent with what we already have in Home Assistant, like in the vacuum integration.

There the naming is "HassVacuumStart" while here you are proposing "HassLawnMowerStartMowing". Wouldn't it be better to use "HassLawnMowerStart" or "HassMowerStart"?

Same for "HassLawnMowerDock", for the vacuum we have "HassVacuumReturnToBase". I think here would be better to use "HassLawnMowerReturnToBase" or "HassMowerReturnToBase". What do you think?

Other than that, I reviewed the code and it looks good to me 😃

@piitaya
Copy link
Member Author
piitaya commented Apr 1, 2025 •
edited
Loading

I reused the names of the Home Assistant services/actions which are inconsistent with the vacuum one 😅

edurenye
edurenye approved these changes Apr 1, 2025
View reviewed changes
Copy link
@edurenye edurenye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I understand, then would be inconsistent with that.
And changing everything should be discussed in a new issue, since it is unrelated to this.
Not sure if it's worth it to change that, because it would be a big breaking change.

But this PR looks good to me 👍

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label May 31, 2025
@edurenye
Copy link

This PR just needs another review

@github-actions github-actions bot removed the stale label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edurenye edurenye edurenye approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed core has-tests integration: lawn_mower new-feature Quality Scale: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piitaya @edurenye
0