Add start mowing and dock intents for lawn mower #3057
Conversation
|
@piitaya Shoundn't we do at least the basic work in English too when we introduce new intents? |
| # lawn mower | ||
| # ----------------------------------------------------------------------------- | ||
|
|
||
| HassLawnMowerStartMowing: |
There was a problem hiding this comment.
I am a bit confused as to whether the domain should be included in the intent name. In most cases it's not (e.g. HassSetVolume, HassMediaPrevious etc.).
I doubt there is another domain apart from lawn_mower which can HassStartMowing) so i don't see the reason for such a long name. I'd even combine HassVacuumStart and HassLawnMowerStartMowing in a simple HassStart intent, with multiple domain support like HassTurnOn.
There was a problem hiding this comment.
Yeah, I used the same logic as vacuum domain to be consistent
There was a problem hiding this comment.
I'd still want @synesthesiam or @balloob to take a look over this before approving this PR
413b011 to
efe918e
Compare
| responses: | ||
| intents: | ||
| HassLawnMowerStartMowing: | ||
| default: "Started" |
There was a problem hiding this comment.
CHOP CHOP ✂️✂️✂️✂️✂️✂️
(joke)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: JLo <jean.loic.pouffier@gmail.com>
Add start mowing and dock intents for lawn mower. Very similar than the vacuum ones.
It can be started/stopped by name, area or globally.
I added sentences in french and basic one in english as I'm not a native speaker.
It needs home-assistant/core#140525 to be merged to have core support.