8000 STORAGE: Making Connection.get_all_buckets a standalone method. by dhermes · Pull Request #716 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

STORAGE: Making Connection.get_all_buckets a standalone method. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2015
Merged

STORAGE: Making Connection.get_all_buckets a standalone method. #716

merged 1 commit into from
Mar 12, 2015

Conversation

dhermes
Copy link
Contributor
@dhermes dhermes commented Mar 12, 2015

See comments in #700 for context.

@tseaver I figured it would be easier to digest moving one method at a time instead of all 4 at once. Still remaining:

$ git grep -e '^    def' -- gcloud/storage/connection.py
gcloud/storage/connection.py:    def __init__(self, project, *args, **kwargs):
gcloud/storage/connection.py:    def build_api_url(self, path, query_params=None, api_base_url=None,
gcloud/storage/connection.py:    def _make_request(self, method, url, data=None, content_type=None,
gcloud/storage/connection.py:    def _do_request(self, method, url, headers, data):
gcloud/storage/connection.py:    def api_request(self, method, path, query_params=None,
gcloud/storage/connection.py:    def get_bucket(self, bucket_name):
gcloud/storage/connection.py:    def create_bucket(self, bucket_name):
gcloud/storage/connection.py:    def delete_bucket(self, bucket_name):
$ git log -1 --pretty=%H
9c783090ea81ec51c6752d24a3637da78a469631

NOTE: I re-ran the storage demo to make sure this worked and noticed the very first line was the license. Without the opening

# Welcome to the gCloud Storage Demo! (hit enter)

the demo is pretty tough to use. I can add the license back at the end of the file if necessary or even after # Welcome ... (/cc @jgeewax).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015
@dhermes dhermes mentioned this pull request Mar 12, 2015
Merged
@dhermes dhermes force-pushed the storage-move-get-all-buckets-to-api branch from 9c78309 to 4f0c483 Compare March 12, 2015 19:33
@tseaver
Copy link
Contributor
tseaver commented Mar 12, 2015

LGTM. I would just move get_bucket, create_bucket, and delete_bucket in a single PR, though.

@dhermes
Copy link
Contributor Author
dhermes commented Mar 12, 2015

Cool. I'll wait on Travis before merging.

We've also got a 3 PR backup in the "merged" queue:
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/54143898
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/54145232
https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/54145337

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into * on GoogleCloudPlatform:master*.

@dhermes dhermes mentioned this pull request Mar 12, 2015
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into 39627c0 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 12, 2015
@dhermes
Merge pull request #716 from dhermes/storage-move-get-all-buckets-to-api
7803d1a 
STORAGE: Making Connection.get_all_buckets a standalone method.
@dhermes dhermes merged commit 7803d1a into googleapis:master Mar 12, 2015
@dhermes dhermes deleted the storage-move-get-all-buckets-to-api branch March 12, 2015 20:20
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
@dhermes
STORAGE: Making Connection.get_bucket a standalone method.
20b9fe3 
Follows on googleapis#716.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
@dhermes
STORAGE: Making Connection.get_bucket a standalone method.
fe8aba7 
Follows on googleapis#716.
This was referenced Mar 12, 2015
Merged
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 13, 2015
@dhermes
STORAGE: Making Connection.get_bucket a standalone method.
341b479 
Follows on googleapis#716.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @coveralls @googlebot
0