8000 Adding back storage.lookup_bucket. by dhermes · Pull Request #700 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Adding back storage.lookup_bucket. #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2015
Merged

Adding back storage.lookup_bucket. #700

merged 1 commit into from
Mar 12, 2015

Conversation

dhermes
Copy link
Contributor
@dhermes dhermes commented Mar 12, 2015

This was originally removed in #588.

@tseaver I'd like to remove all the bucket functions from Connection and move them into api. WDYT?

Also it seems we'd eventually want to add a _require_connection as in datastore.api. It would be nice to come with a re-factor for re-usability (the Batch is the part which needs to be package specific).

FWIW: I came across this while trying to make implicit auth work in storage. Importing Connection in _implicit_environ creates a cycle, essentially because Connection imports Bucket.

8000
@dhermes
Adding back storage.lookup_bucket.
f50d036 
This was originally removed in googleapis#588.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f50d036 on dhermes:add-back-storage-bucket-lookup into * on GoogleCloudPlatform:master*.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2015
@tseaver
Copy link
Contributor
tseaver commented Mar 12, 2015

Moving the bucket-related functions to storage.api SGTM.

@tseaver
Copy link
Contributor
tseaver commented Mar 12, 2015

I'm not sure what the motivation is for re-adding the lookup_bucket() API.

@dhermes
Copy link
Contributor Author
dhermes commented Mar 12, 2015

@tseaver We don't need to add it back, but in the discussion in #588 you asked that we add it back, so I was trying to get the ball rolling with the storage.api module with something simple.

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
@dhermes
STORAGE: Making Connection.get_all_buckets a standalone method.
9c78309 
See comments in googleapis#700 for context.
@dhermes dhermes mentioned this pull request Mar 12, 2015
Merged
@tseaver
Copy link
Contributor
tseaver commented Mar 12, 2015

facepalm I should have gone back to look at #588.

LGTM.

dhermes added a commit that referenced this pull request Mar 12, 2015
@dhermes
Merge pull request #700 from dhermes/add-back-storage-bucket-lookup
39627c0 
Adding back storage.lookup_bucket.
@dhermes dhermes merged commit 39627c0 into googleapis:master Mar 12, 2015
@dhermes
Copy link
Contributor Author
dhermes commented Mar 12, 2015

Cool. I'll rebase #716 now.

@dhermes dhermes deleted the add-back-storage-bucket-lookup branch March 12, 2015 19:25
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
@dhermes
STORAGE: Making Connection.get_all_buckets a standalone method.
4f0c483 
See comments in googleapis#700 for context.
@dhermes dhermes mentioned this pull request Mar 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot
0