10000 Only using explicit namespace when deserializing key pb. by dhermes · Pull Request #292 · googleapis/google-cloud-python · GitHub
[go: up one dir, main page]
Skip to content

Only using explicit namespace when deserializing key pb. #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2014
Merged

Only using explicit namespace when deserializing key pb. #292

merged 2 commits into from
Oct 27, 2014

Conversation

dhermes
Copy link
Contributor
@dhermes dhermes commented Oct 23, 2014

This issue surfaced during review for #282.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 12695c2 on dhermes:unmarshall-key-namespace into b6d3e74 on GoogleCloudPlatform:master.

@dhermes dhermes mentioned this pull request Oct 24, 2014
Merged
tseaver
tseaver reviewed Oct 24, 2014
View reviewed changes
gcloud/datastore/helpers.py
dataset_id = pb.partition_id.dataset_id
namespace = None
if pb.partition_id.HasField('namespace'):
namespace = pb.partition_id.namespace

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

10000 Sign in to view

@dhermes
Adding checks for namespace in datastore helpers test.
156c317 
This is to ensure that values are correctly ignored when
the field isn't set on the protobuf.
@dhermes
Copy link
Contributor Author
dhermes commented Oct 24, 2014

Tests updated. PTAL.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 156c317 on dhermes:unmarshall-key-namespace into b6d3e74 on GoogleCloudPlatform:master.

@dhermes dhermes mentioned this pull request Oct 26, 2014
Merged
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Oct 27, 2014
tseaver added a commit that referenced this pull request Oct 27, 2014
@tseaver
Merge pull request #292 from dhermes/unmarshall-key-namespace
f7d0441 
Only using explicit namespace when deserializing key pb.
@tseaver tseaver merged commit f7d0441 into googleapis:master Oct 27, 2014
@dhermes dhermes deleted the unmarshall-key-namespace branch October 27, 2014 18:03
@dhermes dhermes mentioned this pull request Oct 27, 2014
Merged
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please @vchudnov-g
chore(main): release 1.8.0 (#292)
52707c2 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.2.0 (#292)
072aa83
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
ci(python): fix path to requirements.txt in release script (#292)
30d879d 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 3.7.0 (#292)
d0165f8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#292)
9bfb5f0 
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: detect samples tests in nested directories (#292)
96182b6 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): add nox session to sort python imports (#292)
c3acce2 
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
489af6c 
…292)

Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
parthea added a commit that referenced this pull request Sep 20, 2023
@kchertenko @parthea
fix: add an error message on user environment setup in case of any er…
79c5bb7 
…rors. (#292)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@irataxy
feat(Transcoder): update captions code samples for display name and l… (
529d738 
#292)

* feat(Transcoder): update captions code samples for display name and language

* test bucket should be deleted

* Trigger Build
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.2.0 (#292)
b548953 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(deps): update actions/checkout action to v3 (#292)
5c98b9c 
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
fix(deps): allow protobuf < 5.0.0 (#292)
e87d1b3 
fix(deps): require proto-plus >= 1.22.0
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Bump gapic-generator-python version to 1.3.0 (#292)
df3f11a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: googleapis/googleapis-gen@4313d68
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#292)
ac229b9 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): add .github/CODEOWNERS as a templated file (#292)
e200d2c 
Source-Link: googleapis/synthtool@c5026b3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:0e18b9475fbeb12d9ad4302283171edebb6baf2dfca1bd215ee3b34ed79d95d7

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
59e2deb 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: remove 'pip install' statements from python_library templates …
04e1ce9 
…[autoapprove] (#292)

Source-Link: googleapis/synthtool@1f37ce7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#292)
ba4721f 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v1.42.2 (#292)
48cd120
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#292)
aec0bf6 
Test the minimum supported dependencies in python 3.7 unit tests to prepare for dropping python 3.6
parthea added a commit that referenced this pull request Oct 21, 2023
@release-please @parthea
chore(main): release 2.8.1 (#292)
e19b69a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.0 (#292)
4affa64
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-automl to v2.5.2 (#292)
e2c7689
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: add support for google.analytics.admin.__version___ (#292)
122f0b9 
fix: Add dict typing for client_options
chore: update to gapic-generator-python 1.5.0
chore: use autogenerated setup.py

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 484665853

Source-Link: https://togithub.com/googleapis/googleapis/commit/8eb249a19db926c2fbc4ecf1dc09c0e521a88b22

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c8aa327b5f478865fc3fd91e3c2768e54e26ad44
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-analytics-data to v0.14.0 (#292)
eeb2eda
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#292)
88227ac 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 1.9.1 (#292)
a98b61b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @coveralls @tseaver
0