8000 Adding checks for namespace in datastore helpers test. · googleapis/google-cloud-python@156c317 · GitHub
[go: up one dir, main page]
Skip to content
8000

Commit 156c317

Browse files
dhermesdhermes
committed
Adding checks for namespace in datastore helpers test.
This is to ensure that values are correctly ignored when the field isn't set on the protobuf.
1 parent 12695c2 commit 156c317

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎gcloud/datastore/test_helpers.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def test_wo_dataset(self):
2222
entity_pb = datastore_pb.Entity()
2323
entity_pb.key.partition_id.dataset_id = _DATASET_ID
2424
entity_pb.key.path_element.add(kind=_KIND, id=_ID)
25-
entity_pb.key.partition_id.dataset_id = _DATASET_ID
2625
prop_pb = entity_pb.property.add()
2726
prop_pb.name = 'foo'
2827
prop_pb.value.string_value = 'Foo'
@@ -32,6 +31,7 @@ def test_wo_dataset(self):
3231
self.assertEqual(entity['foo'], 'Foo')
3332
key = entity.key()
3433
self.assertEqual(key._dataset_id, _DATASET_ID)
34+
self.assertEqual(key.namespace(), None)
3535
self.assertEqual(key.kind(), _KIND)
3636
self.assertEqual(key.id(), _ID)
3737

@@ -45,7 +45,6 @@ def test_w_dataset(self):
4545
entity_pb = datastore_pb.Entity()
4646
entity_pb.key.partition_id.dataset_id = _DATASET_ID
4747
entity_pb.key.path_element.add(kind=_KIND, id=_ID)
48-
entity_pb.key.partition_id.dataset_id = _DATASET_ID
4948
prop_pb = entity_pb.property.add()
5049
prop_pb.name = 'foo'
5150
prop_pb.value.string_value = 'Foo'
@@ -56,6 +55,7 @@ def test_w_dataset(self):
5655
self.assertEqual(entity['foo'], 'Foo')
5756
key = entity.key()
5857
self.assertEqual(key._dataset_id, _DATASET_ID)
58+
self.assertEqual(key.namespace(), None)
5959
self.assertEqual(key.kind(), _KIND)
6060
self.assertEqual(key.id(), _ID)
6161

@@ -88,11 +88,13 @@ def test_w_dataset_id_in_pb(self):
8888
pb = self._makePB(_DATASET)
8989
key = self._callFUT(pb)
9090
self.assertEqual(key._dataset_id, _DATASET)
91+
self.assertEqual(key.namespace(), None)
9192

9293
def test_w_namespace_in_pb(self):
9394
_NAMESPACE = 'NAMESPACE'
9495
pb = self._makePB(namespace=_NAMESPACE)
9596
key = self._callFUT(pb)
97+
self.assertEqual(key._dataset_id, None)
9698
self.assertEqual(key.namespace(), _NAMESPACE)
9799

98100
def test_w_path_in_pb(self):

0 commit comments

Comments
 (0)
0